From e1d7cee59b08655c224999b21e9fbf139f5ee54e Mon Sep 17 00:00:00 2001 From: Daniel Golle Date: Sun, 17 Oct 2021 09:34:55 +0100 Subject: [PATCH] jail: netifd: check target netns fd before using it Make sure filehandler is non-negative before using it. Coverity CID: 1492888 Negative returns Signed-off-by: Daniel Golle --- jail/netifd.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/jail/netifd.c b/jail/netifd.c index f6f2df6..0f05ccc 100644 --- a/jail/netifd.c +++ b/jail/netifd.c @@ -469,6 +469,10 @@ int jail_network_start(struct ubus_context *new_ctx, char *new_jail_name, pid_t watch_ubus_service(); netns_fd = ns_open_pid("net", ns_pid); + if (netns_fd < 0) { + ret = ESRCH; + goto errout_inotify; + } netns_updown(host_ubus_ctx, jail_name, true, netns_fd); -- 2.30.2